Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9897] update return type of getFeatureVariable method #887

Merged
merged 3 commits into from
Jan 2, 2024
Merged

[FSSDK-9897] update return type of getFeatureVariable method #887

merged 3 commits into from
Jan 2, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • getFeatureVariable currently return unknown. Updated the return type to more specific type.

Test plan

  • all existing tests should pass

Issues

  • FSSDK-9897

@raju-opti raju-opti requested a review from a team as a code owner December 28, 2023 15:54
@coveralls
Copy link

coveralls commented Dec 28, 2023 •
edited
Loading

Coverage Status

coverage: 90.402%. remained the same
when pulling c8b515e on raju/variable-type
into 2b40193 on master.

@mikechu-optimizely mikechu-optimizely mentioned this pull request Dec 28, 2023
Closed
mikechu-optimizely
mikechu-optimizely requested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments 👇

lib/shared_types.ts Outdated Show resolved Hide resolved
lib/shared_types.ts Show resolved Hide resolved
@mikechu-optimizely mikechu-optimizely removed their assignment Dec 28, 2023
mikechu-optimizely
mikechu-optimizely approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still in favor of having some unit tests cover the FeatureVariableValue type as return values for getFeatureVariable().

I'll leave that decision to you but Approved.

@raju-opti raju-opti merged commit 7e03647 into master Jan 2, 2024
18 checks passed
@raju-opti raju-opti deleted the raju/variable-type branch January 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @mikechu-optimizely